Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filtering): handle multiple events firing for column of type date #10233 #10268

Merged
merged 10 commits into from
Nov 15, 2021
Merged

fix(filtering): handle multiple events firing for column of type date #10233 #10268

merged 10 commits into from
Nov 15, 2021

Conversation

zhosti
Copy link
Contributor

@zhosti zhosti commented Oct 11, 2021

Closes #10233

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@zhosti zhosti added ❌ status: awaiting-test PRs awaiting manual verification filtering labels Oct 11, 2021
gedinakova
gedinakova requested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@gedinakova gedinakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests to cover the changes.

@zhosti zhosti requested a review from gedinakova November 8, 2021 10:35
@zhosti zhosti requested a review from gedinakova November 10, 2021 11:11
@onlyexeption onlyexeption added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 12, 2021
@kdinev kdinev merged commit 4e01d2d into master Nov 15, 2021
@kdinev kdinev deleted the izhostov/issue-10233 branch November 15, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gedinakova gedinakova gedinakova approved these changes

@igdmdimitrov igdmdimitrov Awaiting requested review from igdmdimitrov

Assignees

@onlyexeption onlyexeption

Labels
filtering version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IgxGrid filtering event fires multiple times for column of type 'date'
4 participants
@zhosti @gedinakova @kdinev @onlyexeption